Specify -c .rubocop.yml for bin/rubocop (performance) #6915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speeds up rubocop by 13% based on hyperfine, presumably because it doesn't need to look for the right config file.
simi
approved these changes
Aug 24, 2023
|
@martinemde just out of my curiosity, does it save time if you have no config in parent directories (including home one)? |
|
@simi yes. My ~/.rubocop.yml won't load, so I renamed it when doing this perf test. This is just comparing |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
…nfig Specify -c .rubocop.yml for bin/rubocop (performance) (cherry picked from commit d013399)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
…nfig Specify -c .rubocop.yml for bin/rubocop (performance) (cherry picked from commit d013399)
zzak
added a commit
to zzak/rails
that referenced
this pull request
Dec 29, 2023
Based on rubygems/rubygems#6915 This occurs especially when generating a new rails app within a rails checkout: https://github.com/rails/rails/actions/runs/7360317953/job/20036287021#step:4:171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up rubocop by 13% based on hyperfine, presumably because it doesn't need to look for the right config file.
What was the end-user or developer problem that led to this PR?
Another attempt at #6913 which addresses this as a performance improvement, in addition to a temporary big fix.
Hyperfine shows a 13% improvement over the identical command and environment without
-c .rubocop.yml.What is your fix for the problem, implemented in this PR?
Explicit .rubocop.yml config
Make sure the following tasks are checked