Don't use full indexes unnecessarily on legacy Gemfiles #6916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On legacy Gemfiles with multiple remote sources, where all of them support the compact index API, we were still falling back to full indexes. Fixing this also allows to simplifying the code.
deivid-rodriguez
force-pushed
the
speed-up-multiple-global-remotes-case
branch
from
486e963
to
b1357c8
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 21, 2023
…es-case Don't use full indexes unnecessarily on legacy Gemfiles (cherry picked from commit ef84fd7)
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 21, 2023
…es-case Don't use full indexes unnecessarily on legacy Gemfiles (cherry picked from commit ef84fd7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
On legacy Gemfiles with multiple remote sources, where all of them support the compact index API, we were still falling back to full indexes, making things slow.
What is your fix for the problem, implemented in this PR?
My fix to to remove the special case of "multiple remote Gemfile is involved" and change it to "at least one remote that only supports full indexes is involved".
Fixing this also allows to simplifying the code.
Make sure the following tasks are checked