Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bundle pristine to run in parallel #6927

Merged
merged 1 commit into from Dec 12, 2023

Conversation

segiddins
Copy link
Member

Also fix running when BUNDLE_NO_INSTALL happens to be set, same as with install/update commands

What was the end-user or developer problem that led to this PR?

What is your fix for the problem, implemented in this PR?

Make sure the following tasks are checked

@segiddins
Copy link
Member Author

In rubygems/rubygems.org, this speeds up bundle pristine from like 2:15 to 52s

@segiddins segiddins force-pushed the segiddins/parallel-pristine branch 2 times, most recently from 96c2c20 to 2465ebc Compare December 11, 2023 21:52
@segiddins segiddins marked this pull request as ready for review December 11, 2023 21:53
@segiddins segiddins changed the title [WIP] Allow bundle pristine to run in parallel Allow bundle pristine to run in parallel Dec 11, 2023
Also fix running when BUNDLE_NO_INSTALL happens to be set, same as with install/update commands
Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@segiddins Still feel like this is ready?

@segiddins
Copy link
Member Author

Yup this should now be ready

@martinemde martinemde merged commit 7bcb290 into master Dec 12, 2023
80 checks passed
@martinemde martinemde deleted the segiddins/parallel-pristine branch December 12, 2023 02:10
@deivid-rodriguez deivid-rodriguez changed the title Allow bundle pristine to run in parallel Allow bundle pristine to run in parallel Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants