Add universal-java-19 to CI test setup Gemfile locks #6942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
changed the title
martinemde
force-pushed
the
add-java-19-platform
branch
from
5ec8f95
to
e25d84b
Compare
hsbt
approved these changes
Sep 7, 2023
|
I think a few more lock files need updates to fix this completely. |
martinemde
force-pushed
the
add-java-19-platform
branch
from
e25d84b
to
7114d5a
Compare
martinemde
changed the title
martinemde
force-pushed
the
add-java-19-platform
branch
from
7114d5a
to
26b52e0
Compare
|
I missed adding this to dev_gems.rb.lock, but now this should include all of them. I'll merge if the tests pass without re-resolving the jruby deps. |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
Add universal-java-19 to CI test setup Gemfile locks (cherry picked from commit fa06cbf)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
Add universal-java-19 to CI test setup Gemfile locks (cherry picked from commit fa06cbf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I noticed
Found changes from the lockfile, re-resolving dependencies because you added a new platform to your gemfileduring the Prepare dependencies CI step on jruby windows.What is your fix for the problem, implemented in this PR?
Try adding the platform to see if it removes the extra re-resolve.
Make sure the following tasks are checked