Fix turbo tests Windows monkeypatch #6988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix-turbo-tests-windows-monkeypatch
branch
from
38b0050
to
96d3cd1
Compare
4 tasks
deivid-rodriguez
force-pushed
the
fix-turbo-tests-windows-monkeypatch
branch
from
96d3cd1
to
efe5b58
Compare
|
I just merged #6989, so this should be green now. |
deivid-rodriguez
force-pushed
the
fix-turbo-tests-windows-monkeypatch
branch
3 times, most recently
from
0bf187d
to
8209566
Compare
4 tasks
deivid-rodriguez
force-pushed
the
fix-turbo-tests-windows-monkeypatch
branch
from
8209566
to
230b6d3
Compare
4 tasks
|
Thank you @deivid-rodriguez 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
We haven't been running Bundler specs on Windows since #6739. That PR introduced a monkeypatch for Windows that made tests take a long time (like now) and still report success. So we did not notice that no specs were actually run.
This can be noticed in the last two lines of the current output:
What is your fix for the problem, implemented in this PR?
My fix is to correct the patch to properly apply our previous solution. We should upstream something but for now I just want the tests running again.
Make sure the following tasks are checked