Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow standalone mode to work on a Windows edge case #6989

Merged
merged 1 commit into from
Sep 25, 2023

Commits on Sep 22, 2023

  1. Allow standalone mode to work on a Windows edge case

    If a gem is located in a different drive than the Gemfile, standalone
    mode will fail to generate the `bundler/setup` script, failing with an
    error like
    
    ```
    ArgumentError: different prefix: "C:/" and "D:/a/rubygems/rubygems/bundler/tmp/2/bundled_app/bundle/bundler"
      C:/hostedtoolcache/windows/Ruby/3.0.5/x64/lib/ruby/3.0.0/pathname.rb:528:in `relative_path_from'
      D:/a/rubygems/rubygems/bundler/tmp/2/gems/system/gems/bundler-2.4.20/lib/bundler/installer/standalone.rb:58:in `gem_path'
      D:/a/rubygems/rubygems/bundler/tmp/2/gems/system/gems/bundler-2.4.20/lib/bundler/installer/standalone.rb:33:in `block (2 levels) in paths'
      D:/a/rubygems/rubygems/bundler/tmp/2/gems/system/gems/bundler-2.4.20/lib/bundler/installer/standalone.rb:32:in `map'
      D:/a/rubygems/rubygems/bundler/tmp/2/gems/system/gems/bundler-2.4.20/lib/bundler/installer/standalone.rb:32:in `block in paths'
    ```
    
    I'm fixing this by falling back to using a full path in this case.
    
    This was caught by a failing spec, so I'm not adding new specs.
    deivid-rodriguez committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    3cb9b9a View commit details
    Browse the repository at this point in the history