Abort setup.rb if Ruby is too old
#7011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
approved these changes
Sep 28, 2023
|
👍 |
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
Abort `setup.rb` if Ruby is too old (cherry picked from commit 85edf54)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
Abort `setup.rb` if Ruby is too old (cherry picked from commit 85edf54)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
Abort `setup.rb` if Ruby is too old (cherry picked from commit 85edf54)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 16, 2023
Abort `setup.rb` if Ruby is too old (cherry picked from commit 85edf54)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
We don't officially support rubies under Ruby 2.6, however, up until now it was possible to manually download
setup.rb, and upgrade RubyGems on an older Ruby.This now finally broke.
What is your fix for the problem, implemented in this PR?
Officially forbid this script from running on old rubies.
Closes #7010.
Make sure the following tasks are checked