Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest patch level Ruby releases in CI #7036

Merged
merged 5 commits into from Oct 9, 2023
Merged

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

Not much, just making sure we're on latest.

What is your fix for the problem, implemented in this PR?

Upgrade all the things.

Make sure the following tasks are checked

@martinemde
Copy link
Member

martinemde commented Oct 7, 2023

Windows builds besides 3.2 failed. I'm rerunning with a rebase off master just to see if it's transient, but I'm not hopeful.

Copy link
Member

@simi simi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea about the CI failures, but 👍 on update

@martinemde
Copy link
Member

martinemde commented Oct 7, 2023

CI on windows is failing because etc is a default gem. Here's one of the errors:

You have already activated etc 1.3.0, but your Gemfile requires etc 999999. Since etc is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports etc as a default gem.

@martinemde
Copy link
Member

Aha, I think etc needs to be added to the exclusions. I'll push an update.

@martinemde
Copy link
Member

I don't know if the change I pushed should specifically target windows since they are the only failing runs, or if my patch is fine excluding it always. It would seem to be a no-op on any other build since they were already passing.

@deivid-rodriguez
Copy link
Member Author

Thanks for this. From https://github.com/rubygems/rubygems/actions/runs/6441869064/job/17492104237 I see that 3.2.2 was also passing?

Yes, I normally prefer to limit these exclusions to the environments are versions where the feature is not working, so that we can keep testing other combinations still work fine, and so that we can track how the feature evolves eventually remove the exclusion.

@martinemde
Copy link
Member

martinemde commented Oct 9, 2023

I see that 3.2.2 was also passing?

I tried to keep 3.2 tested. Did I mess up the conditional?

Yes, I normally prefer to limit these exclusions to the environments are versions where the feature is not working

We could constrain to only windows (not sure why it only shows on windows)

@deivid-rodriguez
Copy link
Member Author

deivid-rodriguez commented Oct 9, 2023

I tried to keep 3.2 tested. Did I mess up the conditional?

Oh god, I actually read your message and assumed the exact content of your extra commit without even looking at it 😅. Yeah, the current patch is exactly what I meant, sorry about that.

@deivid-rodriguez
Copy link
Member Author

We could constrain to only windows (not sure why it only shows on windows)

Yep, that's my suggestion. Ruby On Windows adds some customisations through a operating_system.rb file that RubyGems loads when it's required. It could be that this file is now loading etc for some reason.

@martinemde
Copy link
Member

Updated!

@deivid-rodriguez
Copy link
Member Author

I can't approve my own PR but looks great!

Copy link
Member

@simi simi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deivid-rodriguez let's use my approval on your behalf :)

@martinemde
Copy link
Member

Well you don't see this everyday (but I don't work with Ruby on Windows everyday):

       D:/a/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.5.0.dev/lib/bundler/injector.rb:90: [BUG] Segmentation fault
       ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x64-mingw-ucrt]

@deivid-rodriguez
Copy link
Member Author

Never seen that before, and indeed rare to see Ruby segfault these days.

I'd say this may have been surfaced by the recent optimizations merged (maybe #6970?), since the last build on master also run into that, and also a separate PR is having issues with that spec.

@martinemde martinemde merged commit 78e31d4 into master Oct 9, 2023
92 checks passed
@martinemde martinemde deleted the latest-rubies-in-ci branch October 9, 2023 20:15
deivid-rodriguez pushed a commit that referenced this pull request Oct 13, 2023
deivid-rodriguez pushed a commit that referenced this pull request Oct 13, 2023
deivid-rodriguez pushed a commit that referenced this pull request Oct 13, 2023
deivid-rodriguez pushed a commit that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants