New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest patch level Ruby releases in CI #7036
Conversation
c598d86
to
0a02204
Compare
Windows builds besides 3.2 failed. I'm rerunning with a rebase off master just to see if it's transient, but I'm not hopeful. |
0a02204
to
2e50901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea about the CI failures, but 👍 on update
CI on windows is failing because
|
Aha, I think etc needs to be added to the exclusions. I'll push an update. |
3f3abd4
to
eab8f57
Compare
I don't know if the change I pushed should specifically target windows since they are the only failing runs, or if my patch is fine excluding it always. It would seem to be a no-op on any other build since they were already passing. |
Thanks for this. From https://github.com/rubygems/rubygems/actions/runs/6441869064/job/17492104237 I see that 3.2.2 was also passing? Yes, I normally prefer to limit these exclusions to the environments are versions where the feature is not working, so that we can keep testing other combinations still work fine, and so that we can track how the feature evolves eventually remove the exclusion. |
I tried to keep 3.2 tested. Did I mess up the conditional?
We could constrain to only windows (not sure why it only shows on windows) |
Oh god, I actually read your message and assumed the exact content of your extra commit without even looking at it 😅. Yeah, the current patch is exactly what I meant, sorry about that. |
Yep, that's my suggestion. Ruby On Windows adds some customisations through a |
eab8f57
to
834ae8a
Compare
Updated! |
I can't approve my own PR but looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deivid-rodriguez let's use my approval on your behalf :)
Well you don't see this everyday (but I don't work with Ruby on Windows everyday):
|
Never seen that before, and indeed rare to see Ruby segfault these days. I'd say this may have been surfaced by the recent optimizations merged (maybe #6970?), since the last build on master also run into that, and also a separate PR is having issues with that spec. |
(cherry picked from commit 78e31d4)
(cherry picked from commit 78e31d4)
(cherry picked from commit 78e31d4)
(cherry picked from commit 78e31d4)
What was the end-user or developer problem that led to this PR?
Not much, just making sure we're on latest.
What is your fix for the problem, implemented in this PR?
Upgrade all the things.
Make sure the following tasks are checked