Deprecate bundle plugin install --local-git=

[ccutrer]

What was the end-user or developer problem that led to this PR?

Adding the --path param, I noticed --git and --local-git have identical implementations.

What is your fix for the problem, implemented in this PR?

Keep --local-git as an undocumented alias for --git. Use the same actual implementation now. No functionality change.

Make sure the following tasks are checked

• Describe the problem / feature
• Write tests for features and bug fixes
• Write code to solve the problem
• Make sure you follow the current code style and write meaningful commit messages without tags

[deivid-rodriguez]

Looks great, just added a comment to add an explicit runtime deprecation.

I think this option is mostly discoverable through CLI help, and you already included a note about deprecation there, but we print a runtime message for other deprecated flags, so I think it does not hurt to also do it here.

[deivid-rodriguez]

@ccutrer Sorry for my slow reviews, the plugin work you were doing is awesome. Whenever you're ready to continue, I am too!

[ccutrer]

👍 I was on vacation for a week, then got Covid, so I'm a bit backlogged, but I promise to get back to it as soon as I can.

[deivid-rodriguez]

Hope you enjoyed your vacation, and are feeling better now after Covid. Thanks so much for the work!

[deivid-rodriguez]

Since the flag is deprecated in Bundler 2 and will make commands using it fail in Bundler 3, this is making some specs fail. If they are unrelated to the setting itself, they can be changed to use --git.

[ccutrer]

The failing specs are all ones I left in to ensure the deprecated behavior still works. I've add spec filters to them so they won't run at all under bundler 3.

[deivid-rodriguez]

Sorry for the lack of feedback here.

By adding the filters, we'll lose the specs on Bundler 3, right? I think it's better to migrate the specs to use --git instead? We could limit usage of --local-git in specs to an explicit test at bundler/spec/other/major_deprecation_spec.rb. That's what we do for other deprecations.

[ccutrer]

Ahhh, yes, I could move the specs for deprecated features there. I didn't know it existed. The specs that have the filters are already duplicates of ones that use --git, so we won't lose coverage on Bundler 3.

[deivid-rodriguez]

Are we testing that --git works with local git repos? I checked superficially and didn't find those specs.

[deivid-rodriguez]

I addressed what I think was left to do here.