Allow explicitly uninstalling multiple versions of same gem #7063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
kstevens715
force-pushed
the
gem-uninstall
branch
4 times, most recently
from
31df021
to
b73ea9d
Compare
kstevens715
force-pushed
the
gem-uninstall
branch
from
b73ea9d
to
7aebd99
Compare
kstevens715
changed the title
|
Thanks so much, just approved CI to run for you, let's see how it goes! |
Currently, you can install multiple versions of the same gem just fine: ``` $ gem install simplecov:0.19.0 simplecov:0.22.0 Fetching simplecov-0.19.0.gem Successfully installed simplecov-0.19.0 Parsing documentation for simplecov-0.19.0 Installing ri documentation for simplecov-0.19.0 Done installing documentation for simplecov after 0 seconds Fetching simplecov-0.22.0.gem Successfully installed simplecov-0.22.0 Parsing documentation for simplecov-0.22.0 Installing ri documentation for simplecov-0.22.0 Done installing documentation for simplecov after 0 seconds 2 gems installed ``` But to uninstall both of them, you need to run the equivalent uninstall command twice: ``` ~$ gem uninstall simplecov:0.19.0 simplecov:0.22.0 Successfully uninstalled simplecov-0.22.0 ~$ gem uninstall simplecov:0.19.0 simplecov:0.22.0 Gem 'simplecov' is not installed Successfully uninstalled simplecov-0.19.0 ``` This resolves that problem by using the gem's full name (which includes the version) when tracking which ones have already been uninstalled so when it gets to the second version listed it doesn't think it was already uninstalled.
kstevens715
force-pushed
the
gem-uninstall
branch
from
7aebd99
to
d96101b
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2023
Allow explicitly uninstalling multiple versions of same gem (cherry picked from commit a3696cb)
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2023
Allow explicitly uninstalling multiple versions of same gem (cherry picked from commit a3696cb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
As described in #6979, you can install multiple versions of the same gem just fine:
But to uninstall both of them, you need to run the equivalent uninstall command twice:
What is your fix for the problem, implemented in this PR?
When just a gem name is specified without a version, there's code so the uninstall only happens once for a gem when there's multiple versions installed which makes sense because the next step lets the user choose which specific version or if they want to uninstall all versions. This PR bypasses the skip logic if a specific gem version was given so that all can be uninstalled.
Make sure the following tasks are checked