Use a shared connection pool for fetching gems #7079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #7076 Bundler will now use the same (shared) remote fetcher instance that RubyGems uses. This will allow installs to use a shared connection pool, which represents a significant performance improvement on a clean install.
martinemde
approved these changes
Oct 19, 2023
deivid-rodriguez
approved these changes
Oct 19, 2023
simi
approved these changes
Oct 19, 2023
deivid-rodriguez
added
rubygems: performance
bundler: performance
and removed
rubygems: performance
labels
|
Thank you for the fix @segiddins! When I was thinking about how to solve this, I thought sharing the same fetcher object between multiple threads (when |
|
That PR addresses my concerns, thanks! |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 8, 2023
…ce-in-bundler Reuse Gem::RemoteFetcher instance in bundler (cherry picked from commit 54a7a7a)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 8, 2023
…ce-in-bundler Reuse Gem::RemoteFetcher instance in bundler (cherry picked from commit 54a7a7a)
deivid-rodriguez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7076
Bundler will now use the same (shared) remote fetcher instance that
RubyGems uses.
This will allow installs to use a shared connection pool, which
represents a significant performance improvement on a clean install.