Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less exceptional user install #7100

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Less exceptional user install #7100

merged 4 commits into from
Oct 25, 2023

Commits on Oct 24, 2023

  1. Make the user installation less exceptional 

    The main purpose is to put handling of user installation into the same
place as e.g. handling the --build-root option handling. There is no
reason why the --build-root option should not prefix also paths used for
user installation.

Please note that the `util_installer` in
`test_generate_plugins_with_user_install` enforced the `:install_dir`,
which is against what user install is about.
    @voxik
    voxik committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0b10cb4 View commit details
    Browse the repository at this point in the history

  2. Check for :install_dir precedence over :user_install

    @voxik
    voxik committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6539da0 View commit details
    Browse the repository at this point in the history

  3. Don't use util_installer for user install 

    It is not nice to require install directory to be always specified,
while this option is later ignored for user installed gems.

Actually, the next step will be to remove `check_install_dir` check and
let the install dir override the user install.
    @voxik
    voxik committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    beb79e9 View commit details
    Browse the repository at this point in the history

  4. Allow --install-dir to be specified together with --user-install 

    The combination of `install-dir` and `--user-install` used to be
disabled for no good reason. This even makes problem on Linux
distributions such as Fedora, where `--user-install` is set by default
via operating_system.rb.

The `--install-dir` is already prefered over the `--user-install` by
the implementation, therefore just drop the check.
    @voxik
    voxik committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    313b1c5 View commit details
    Browse the repository at this point in the history