-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend license attribute in gemspec #713
Conversation
Link to GitHub license picker Explain importance of specifying a license
Overall this looks good! I would comment directly on the lines, but I am on the bus and desktop view typing is painfully slow. Can you remove the empty :category: lines? They aren't needed because category only applies to methods and attributes. Does the updated WARNING text fit on one line with 80 columns? I would prefer the URL to stand alone so it's easier to cut and paste. |
@@ -331,6 +333,7 @@ def files | |||
|
|||
###################################################################### | |||
# :section: Optional gemspec attributes | |||
# :category: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @drbrain, remove
@drbrain updated, also updated the related PR in rubygems/guides#67 (not sure what your usual process is) |
per @drbrain Also, removed unnecessary :category: tags
Add recommend license attribute for gemspec
Great! It looks like the spec page in the guides should be manually regenerated? |
That will happen automatically with the next release. I'm not sure if the changes to specification are cosmetic only, so I'd like to wait. |
@drbrain Sorry, forgot about the github feature of linking issues... will fix |
No problem! If github sends emails for these I don't recall if I noticed |
Per discussion in rubygems/guides#67
@drbrain I built the spec guide and it looked fine.
RUBYGEMS_DIR=$HOME/repos/forked/rubygems rake spec_guide --trace