Fix invalid platform removal missing adjacent platforms #7170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
force-pushed
the
platform-removal-fix
branch
from
518ca87
to
4ce66c4
Compare
deivid-rodriguez
approved these changes
Nov 21, 2023
|
Thanks for the fix! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When researching #7169, I noticed if you had multiple invalid platforms then not all will be removed if they are located on adjacent lines. This is because we were modifying the array while iterating over it.
What is your fix for the problem, implemented in this PR?
The fix is to iterate in reverse order, so we are not shifting things we've not yet reached.
The existing test was modified to include two invalid platforms rather than just one, which should in theory cover this bug.
Make sure the following tasks are checked