Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Magnus library in Rust extension gem template #7204

Merged
merged 1 commit into from Nov 29, 2023

Conversation

ggmichaelgo
Copy link
Contributor

What was the end-user or developer problem that led to this PR?

Magnus, the Ruby bindings library used in the template for a Rust extension gem has released a newer version. It would be helpful if the generated gem skeleton used the latest version.

What is your fix for the problem, implemented in this PR?

The version number has been updated in the template Cargo.toml, and a few changes have been made to lib.rs.tt to account for API changes.

The newer version of Magnus uses the rb-sys' new stable API for RArray and RString. This update will increase stability of Rust gems to be used with different versions of Ruby.
Also, the newer version fixes the compile error in RString#bytes feature.

Thank you @matsadler @ianks and @gmalette for these update on Magnus!

Make sure the following tasks are checked

Copy link

welcome bot commented Nov 28, 2023

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

@ggmichaelgo ggmichaelgo marked this pull request as ready for review November 28, 2023 15:51
@hsbt hsbt enabled auto-merge November 29, 2023 01:35
@hsbt hsbt merged commit 9ad5633 into rubygems:master Nov 29, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants