-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --build-root
option incorrectly installing to user dir inside build root
#7212
Conversation
d3689a3
to
f2c7b69
Compare
--build-root
option incorrectly installing to user dir inside build root
@deivid-rodriguez here's a patch that takes this PR and both fixes If you'd like, I can push the changes myself. Otherwise, you can download the patch file and run (Since this is your PR, I didn't want to push changes without your permission.) |
f2c7b69
to
e6299f9
Compare
Your patch looks good but broke a couple of tests. I pushed a small tweak to fix that. Also noticing that the test you added already passes without the fix? Looking into that now too. |
7e4f1b6
to
65f5939
Compare
I amended the test so that it properly reproduces the problem, and also added another test to the change in approach to the fallback. I had removed all previous tests because they were dependent on the previous implementation but I had not added a new test to cover the new approach. That's now in place too! |
65f5939
to
2fae16f
Compare
@duckinator This is ready from my side. I'd just like to give this a final rebase & some commit squashing, but I'll wait for a final review pass from you in case you have some comments! |
@deivid-rodriguez rebase and squash away. 👍 |
2173b27
to
6aa688e
Compare
If an error happens during the install command, it will fail in an strange way right now.
6aa688e
to
6a06b07
Compare
What was the end-user or developer problem that led to this PR?
I was hoping that this changes would fix #7083, but I can't reproduce the issue either in current master.Changes in #5327 made
--build-root
start installing into user dir inside the build root.What is your fix for the problem, implemented in this PR?
It builds the fix on a change in the approach to #5327 that makes it easier to fix this kind of issue and should also be more robust, since it does not require to keep a list of commands that the warning applies to, and to save whether we fallback or not to check the result somewhere else.
With the new approach in place, it gets simpler to fix the problem, since
build-root
is prepended in the exact same place where the fallback to installing to the user directory happens.Fixes #7083.
Make sure the following tasks are checked