Warn for duplicate meta data links when building gems #7213
Conversation
|
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
lib/rubygems/specification_policy.rb
Outdated
| keys = copies.map(&:first).join("\n") | ||
| warning <<-WARNING | ||
| You have specified the uri: | ||
| #{uri} |
There was a problem hiding this comment.
nit: indent the URI and keys so it's easier to read?
There was a problem hiding this comment.
whoops, misread that as indent the heredoc vs the actual output. updated.
Match order of METADATA_LINK_KEYS to order used by rubygems.org in Links model. Add missing download_uri key.
martinemde
force-pushed
the
warn_for_duplicate_metadata_links
branch
2 times, most recently
from
2aa89b7
to
d2922cd
Compare
|
Squashed and rebased. Setting to auto-merge. |
deivid-rodriguez
changed the title
Match order of METADATA_LINK_KEYS to order used by rubygems.org in Links model Add missing download_uri key
What was the end-user or developer problem that led to this PR?
This came out of a discussion around the fix to rubygems/rubygems.org#3755
What is your fix for the problem, implemented in this PR?
Per the suggestion from @simi I've added a warning when duplicate links are present in the metadata.
I also noticed the METADATA_LINK_KEYS constant was missing download_uri
Make sure the following tasks are checked