Fix Bundler setup instructions #7216
Conversation
|
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
bundler/doc/development/SETUP.md
Outdated
|
|
||
| $ rake setup | ||
| $ bin/rake spec:parallel_deps |
There was a problem hiding this comment.
Instead of joining these, I could also apply the format from e.g. CONTRIBUTING.md and remove the leading $ so that GitHub's handy little copy-to-clipboard button works directly. 🤓
There was a problem hiding this comment.
This could also say bin/rake setup spec:parallel_deps.
There was a problem hiding this comment.
Haha, yes. 🤦🏼
Changed it accordingly.
When trying to follow the instructions locally, they did not work until I realized they were out of order. The Rake command needs to be executed in the root directory before switching to the bundler directory.
franzliedke
force-pushed
the
fl/fix-bundler-dev-instructions
branch
from
0edee2f
to
f6c88f0
Compare
|
Thank you for noticing and fixing this! |
What was the end-user or developer problem that led to this PR?
Following the developer setup instructions led to failed commands.
What is your fix for the problem, implemented in this PR?
The Rake command needs to be executed in the root directory before switching to the bundler directory.
I reordered the instructions accordingly.
Make sure the following tasks are checked