Remove non-transparent requirement added to prerelease gems #7226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
remove-hidden-constraint-on-rubygems-on-prerelease-versions
branch
from
3a7a5b0
to
d86997e
Compare
hsbt
approved these changes
Dec 8, 2023
martinemde
approved these changes
Dec 10, 2023
| @@ -2682,11 +2682,6 @@ def version=(version) | |||
| @version = Gem::Version.create(version) | |||
| return if @version.nil? | |||
|
|
|||
| # skip to set required_ruby_version when pre-released rubygems. | |||
| # It caused to raise CircularDependencyError | |||
There was a problem hiding this comment.
Need to update the comment on def version= above as well.
There was a problem hiding this comment.
Thanks for catching that!
|
Ready to merge after the comment is fixed. (just a note to self, since I almost came back and merged this) |
I think we can safely assume these days that all RubyGems and Bundler versions that will ever bundle a new gem created in 2023 support prereleases. So this non transparent requirement is not necessary. In my opinion, it should be the gem author to explicitly add this constraint, not RubyGems.
deivid-rodriguez
force-pushed
the
remove-hidden-constraint-on-rubygems-on-prerelease-versions
branch
from
d86997e
to
b165e6d
Compare
deivid-rodriguez
deleted the
remove-hidden-constraint-on-rubygems-on-prerelease-versions
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I recall this requirement confusing me while working in the resolver, since it could lead to different resolution process when working in master (2.5.0.dev currently) than when working with a released version.
It feels non transparent and too magical. I think we can safely assume these days that all RubyGems and Bundler versions that will ever bundle a new gem created in 2023 support prereleases.
So this non transparent requirement is not necessary. It should be the gem author to explicitly add this kind of constraint, not RubyGems. Setting the version of a gem should do just that, set the version.
This has also caused Circular require issues in the past, and has special conditions attached to workaround that.
What is your fix for the problem, implemented in this PR?
Remove the extra constraint.
Make sure the following tasks are checked