Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate documentation to be generated with nronn #7227

Merged
merged 2 commits into from Dec 7, 2023
Merged

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

We're using very out of date unmaintained ronn gem to generate our docs.

What is your fix for the problem, implemented in this PR?

Switch to a more up to date fork, nronn.

Closes #6941.

Make sure the following tasks are checked

If it's not there, when migrating to `nronn`, generated man page is
messed up.
@deivid-rodriguez
Copy link
Member Author

Only noticed one visual difference which was fixed by adding an extra blank line at 7161347.

Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this!

@deivid-rodriguez deivid-rodriguez merged commit 65fa782 into master Dec 7, 2023
66 checks passed
@deivid-rodriguez
Copy link
Member Author

I should've probably asked @tnir first if it's fine for us to start using nronn and if he's committed to maintaining it. If you're no longer interested, I'm happy to get added as a maintainer!

hsbt added a commit to hsbt/ruby that referenced this pull request Dec 8, 2023
  Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
hsbt added a commit to ruby/ruby that referenced this pull request Dec 8, 2023
  Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ronn by ronn-ng
3 participants