Resolve ruby file: ".ruby-version" relative to containing Gemfile
#7250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
As pointed out in #7219 When Bundler.root is not the same as the Gemfile's dirname, the ruby-version file path is evaluated incorrectly.
Fixes #7219
Also will help Shopify/ruby-lsp#1698 since that's where the bug originally arose.
What is your fix for the problem, implemented in this PR?
Resolves path in
ruby file: "path"relative to the Gemfile that is being evaluated.Make sure the following tasks are checked