Vendor uri in RubyGems #7386
Merged
Vendor uri in RubyGems #7386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
vendor-uri
branch
5 times, most recently
from
fe77307
to
6d29805
Compare
simi
approved these changes
Jan 25, 2024
deivid-rodriguez
force-pushed
the
vendor-uri
branch
from
6d29805
to
3a262f5
Compare
|
Added one test, should be ready now! |
|
Technically this has changes in both RubyGems and Bundler. However, the more meaningful change is to start vendoring URI in RubyGems. So I'll put this in the changelog of RubyGems and silently sneak in Bundler changes with the corresponding Bundler release. |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Jan 30, 2024
…t ToQueryTest::URI` This commit addresses CI failure at https://buildkite.com/rails/rails-nightly/builds/108#018d57ac-4f2a-45f1-86b9-9015a7b0a463/1165-2002 * Error addressed by this commit ``` $ ruby -v ruby 3.4.0dev (2024-01-30T10:19:23Z master 86547fd69d) [x86_64-linux] $ rm Gemfile.lock $ bundle install $ cd activesupport $ bin/test test/core_ext/object/to_query_test.rb -n test_hash_not_sorted_lexicographically_for_nested_structure ... snip ... E Error: ToQueryTest#test_hash_not_sorted_lexicographically_for_nested_structure: NameError: uninitialized constant ToQueryTest::URI test/core_ext/object/to_query_test.rb:90:in `test_hash_not_sorted_lexicographically_for_nested_structure' bin/test test/core_ext/object/to_query_test.rb:79 Finished in 0.000385s, 2597.3082 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 1 errors, 0 skips $ ``` This behavior has been introduced since Ruby 3.4.0dev vendors URI from top level to `Gem::URI` via ruby/ruby@d64d0b5 . Here is the RubyGems one. rubygems/rubygems#7386
4 tasks
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 5, 2024
Vendor uri in RubyGems (cherry picked from commit 391e680)
viralpraxis
pushed a commit
to viralpraxis/rails
that referenced
this pull request
Mar 24, 2024
…t ToQueryTest::URI` This commit addresses CI failure at https://buildkite.com/rails/rails-nightly/builds/108#018d57ac-4f2a-45f1-86b9-9015a7b0a463/1165-2002 * Error addressed by this commit ``` $ ruby -v ruby 3.4.0dev (2024-01-30T10:19:23Z master 86547fd69d) [x86_64-linux] $ rm Gemfile.lock $ bundle install $ cd activesupport $ bin/test test/core_ext/object/to_query_test.rb -n test_hash_not_sorted_lexicographically_for_nested_structure ... snip ... E Error: ToQueryTest#test_hash_not_sorted_lexicographically_for_nested_structure: NameError: uninitialized constant ToQueryTest::URI test/core_ext/object/to_query_test.rb:90:in `test_hash_not_sorted_lexicographically_for_nested_structure' bin/test test/core_ext/object/to_query_test.rb:79 Finished in 0.000385s, 2597.3082 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 1 errors, 0 skips $ ``` This behavior has been introduced since Ruby 3.4.0dev vendors URI from top level to `Gem::URI` via ruby/ruby@d64d0b5 . Here is the RubyGems one. rubygems/rubygems#7386
mackuba
added a commit
to mackuba/minisky
that referenced
this pull request
Mar 31, 2024
Apparently uri specifically is problematic because rubygems loads it before we get to bundler? (older version at least) rubygems/rubygems#7386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
RubyGems loads URI internally. This can cause gem activation conflicts in Bundler when an app is locked to old URI, but RubyGems internally loads a different default version.
What is your fix for the problem, implemented in this PR?
Vendor URI in RubyGems.
Fixes #7178 (comment).
Make sure the following tasks are checked