Add gitlab: git source shorthand

[jgarber623]

First off, thank you for considering this Pull Request! I appreciate your time.

What was the end-user or developer problem that led to this PR?

In #7210, I noted the existence of the github: and bitbucket: shorthands for installing gems from Git sources. I proposed adding two new providers, gitlab: and codeberg:, for the notable Git services Gitlab and Codeberg. The proposal to add Gitlab was accepted.

The changes proposed in this PR would provide a small quality-of-life improvement for users with Ruby dependencies whose source repositories exist somewhere other than GitHub.

Resolves #7210.

What is your fix for the problem, implemented in this PR?

This PR adds gitlab: shorthand with similar functionality to the existing github: shorthand:

gem "gitlab-sdk", gitlab: "gitlab-org/analytics-section/product-analytics/gl-application-sdk-rb"

Merge Request URLs are also supported for each new shorthand:

gem "gitlab-sdk", gitlab: "https://gitlab.com/gitlab-org/analytics-section/product-analytics/gl-application-sdk-rb/-/merge_requests/27"

Make sure the following tasks are checked

• Describe the problem / feature
• Write tests for features and bug fixes
• Write code to solve the problem
• Make sure you follow the current code style and write meaningful commit messages without tags

[welcome]

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

[deivid-rodriguez]

Thanks!

I think in the related issue there was pretty much consensus on adding Gitlab. I think codeberg was more unclear, though. In particular, thresholds proposed by @indirect at #7210 (comment) would exclude it.

So we can proceed in 2 ways:

• Add Gitlab only for now.
• Wait a bit until we make a final decision.

Regarding the implementation, it's pretty confusing, but the tests you added would be for an implementation of the Bundler DSL that actually lives in RubyGems and it's not really used by Bundler at the moment. The proper place for these tests would be in bundler/spec/bundler/dsl_spec.rb.

[indirect]

I think we should definitely add GitLab. I am less clear on whether we should add Codeberg (and Sourcehut, and Beanstalk, and CodeCommit, and Cloud Source Repositories, and Launchpad, and Keybase, and Planio, and Tuleap). My main hesitation adding smaller repository sources is churn, having to constantly do work to update our shortcuts if URLs change or services shut down or move.

If we see consistent user requests for other sources, I am fine with adding them. So far I think we have only seen that for GitLab.

[deivid-rodriguez]

@jgarber623 Could you limit this PR to adding support for the gitlab shorthand?

[jgarber623]

Thanks for the feedback, y'all! I've reverted the commit adding the Codeberg shortcut. Let me know if you'd rather avoid the revert commit and I can force push. Not sure which of GitHub's many merge approaches you prefer.

@deivid-rodriguez My apologies for that first pass at the tests. I've added a bunch of gitlab-specific ones in 98905e6, basing them on the existing github specs (since the two shortcuts are mostly the same). Let me know if there's anything else worth testing.

Thanks again and appreciate your consideration!

[deivid-rodriguez]

No problem at all! Not your fault, it's a bit confusing 😅

Yes, if you can squash everything into one commit, I do prefer that 👍.

Thanks for the PR!

[jgarber623]

@deivid-rodriguez All set. Squashed the commits, brought my branch up-to-date with main, and force-pushed. Should be a nice clean merge.

Thanks again for the feedback!

[deivid-rodriguez]

Thank you!

[martinemde]

Waiting for tests to be fixed. Please cleanup white space.

[jgarber623]

Formatting issues addressed. 👍🏻

Both rspec ./spec/quality_spec.rb and rake rubocop are reporting all green.

[martinemde]

Thanks @jgarber623 !