Use full path for instance_eval in Bundler::DSL#eval_gemfile
#7471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good with an added test! |
|
👍 I'll get some tests written. I wanted to push up (as a draft) just to make sure it didn't break anything else before I invested time in writing a test. |
ccutrer
added a commit
to ccutrer/bundler-multilock
that referenced
this pull request
Feb 12, 2024
ccutrer
added a commit
to instructure/bundler-multilock
that referenced
this pull request
Feb 12, 2024
so that __dir__ and __FILE__ will work properly from within that gemfile fragment, if eval_gemfile is given a relative path
ccutrer
force-pushed
the
eval_gemfile_absolute_path
branch
from
e085fbb
to
d521bf9
Compare
|
Spec added. |
simi
approved these changes
Feb 15, 2024
deivid-rodriguez
pushed a commit
that referenced
this pull request
Mar 20, 2024
Use full path for `instance_eval` in `Bundler::DSL#eval_gemfile` (cherry picked from commit 484e1aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When using
eval_gemfile("../gemfile_prefix.rb")with a Gemfile that's not in the current directory,__dir__and__FILE__end up being
".."and"gemfile_prefix.rb"respectively, which is not usable from within gemfile_prefix.rb in order to find other relative files, sinceDir.pwdis not the Gemfile's directory.What is your fix for the problem, implemented in this PR?
eval_gemfilealready calculates the absolute path to the gemfile fragment; just pass that toinstance_eval. This makes it behave the same wrt__dir__and__FILE__asrequire_relative.Make sure the following tasks are checked