Fix resolver error message when it runs out of versions due to --strict --patch filtering out everything
#7527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
deivid-rodriguez
force-pushed
the
resolver-improvements
branch
2 times, most recently
from
abbba71
to
dd62e13
Compare
And also so that it matches the method used by main PubGrub sample resolver class.
We do that when first caching versions, and then it's no longer necessary.
So that we don't need to reverse the Array.
We just need to filter versions belonging to the range, but don't need anything else.
deivid-rodriguez
force-pushed
the
resolver-improvements
branch
from
dd62e13
to
1ea44b3
Compare
deivid-rodriguez
changed the title
--strict --patch filtering out everything--strict --patch filtering out everything
deivid-rodriguez
added a commit
that referenced
this pull request
Apr 4, 2024
Fix resolver error message when it runs out of versions due to `--strict --patch` filtering out everything (cherry picked from commit a384c33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
In some resolver edge cases, we end up giving a confusing error message.
What is your fix for the problem, implemented in this PR?
Refactor the resolver to detect the situation and give a better error. While figuring things out, I also included several resolver improvements like avoiding version sorting when not necessary, and sorting in descending order directly instead of sorting in ascending order and then reversing.
Fixes #7369.
Supersedes #7376.
Make sure the following tasks are checked