Add --glob flag to bundle add

[thedavemarshall]

Bundler online documentation says that if the gem is located within a subdirectory of a git repository, you can use the :glob option to specify the location of its .gemspec, docs

gem 'cf-copilot', git: 'https://github.com/cloudfoundry/copilot', glob: 'sdk/ruby/*.gemspec'

This change allows for equivalent functionality from the bundler CLI

bundle add cf-copilot --git=https://github.com/cloudfoundry/copilot --glob='sdk/ruby/*.gemspec'

What was the end-user or developer problem that led to this PR?

I'm working on some projects that require gems from remote git sources, and sometimes these projects don't specify the .gemspec file at the root of the repo. Instead of manually editing the Gemfile, I'd like to use bundler's CLI where possible.

What is your fix for the problem, implemented in this PR?

My fix is to pass-through the glob option from Bundler::CLI#add(*gems), to Bundler::Dependency#glob to be used in Bundler::Injector#build_gem_lines()

Make sure the following tasks are checked

• Describe the problem / feature
• Write tests for features and bug fixes
• Write code to solve the problem
• Make sure you follow the current code style and write meaningful commit messages without tags

[welcome]

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

[deivid-rodriguez]

I don't think this option gets a lot of use, but seems nice to have all options mapped to bundle add flags 👍

I think people will need to run this with quotes, otherwise most shells will automatically expand * if run from a directory with gemspecs matching the glob. But there's not much we can do about that. Maybe change tests examples to use quotes, explicitly document it? Not sure.

[thedavemarshall]

@deivid-rodriguez good points, thanks for the feedback!

I think people will need to run this with quotes, otherwise most shells will automatically expand * if run from a directory with gemspecs matching the glob. But there's not much we can do about that. Maybe change tests examples to use quotes, explicitly document it? Not sure.

I've changed the specs to use single quotes around the --glob value when invoking bundle add, and I've added banner: text for the CLI explaining that the globs will be expanded with Ruby and recommending single quotes.

[deivid-rodriguez]

Nice, thanks! This looks good to me! There's a failed spec unrelated to your changes, don't worry about that. I'll merge this next week 👍

[deivid-rodriguez]

Thanks!