Fix the update_rubygems inconsistency (--disable-gems) #7658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
gem update --system
, as opposed toupdate_rubygems
, disables gems (--disable-gems
) when runningsetup.rb
. As a resultsetup.rb
gets reexecuted if one usesupdate_rubygems
. Fixes #7621.What is your fix for the problem, implemented in this PR?
Apparently when
--disable-gems
was added togem update --system
,update_rubygems
was left as is. My solution is to syncupdate_rubygems
withgem update --system
(make it pass--disable-gems
tosetup.rb
as well).Make sure the following tasks are checked