Fixed crash if a .gemspec has a string for require_paths variable.

[danielpclark]

Addresses open issue "require_path from gemspec is type sensitive. #890".

[luislavena]

Why not use Array(@require_paths) instead?

a = %w(lib ext) #=> ["lib", "ext"]
b = "lib"
Array(a) #=> ["lib", "ext"]
Array(b) #=> ["lib"]

[danielpclark]

You're right that's much nicer. I found two tests that had the wrong variable require_path instead of require_paths set; require_path isn't used. I'll post the chages here in the pull request.

[luislavena]

@danielpclark thank you for your pull request.

Would you mind adding a test to verify this fix?

Thank you.

[danielpclark]

I've fixed an existing test. Changed require_path to require_paths since require_path doesn't actually get used. Without the Array(@require_paths) fix the tests would fail. Thank you for your nicer looking code tip @luislavena .

[drbrain]

I'm afraid the changes to the implementation may re-break elsewhere if @require_paths is used.

Instead, can you replace the attr_accessor :require_paths with a method that always returns an Array and remove use of @require_paths in both basic_specification.rb and specification.rb

[danielpclark]

@zzak

Shouldn't attr_writer :require_paths in specifications.rb now be

def require_paths= paths
  @require_paths = Array(paths)
end

per @drbrain's suggestion.

And

def require_path= path
  self.require_paths = [path]
end

should now be

def require_path= path
  self.require_paths = Array(path)
end

to avoid getting an array within an array with [] to [[]]?

I've submitted it to commit #909

[luislavena]

to avoid getting an array within an array with [] to [[]]?

$ irb
irb(main):001:0> a = "lib"
=> "lib"
irb(main):002:0> b = ["lib"]
=> ["lib"]
irb(main):003:0> c = Array(a)
=> ["lib"]
irb(main):004:0> d = Array(b)
=> ["lib"]
irb(main):005:0>

[danielpclark]

Yes sir. You showed that to me earlier when I used the .flatten method. It is the right way to do it. I had later seen it in one of Avdi Grimm's presentations.