Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help for list and search commands #905

Merged
merged 1 commit into from May 8, 2014

Conversation

ggilder
Copy link
Contributor

@ggilder ggilder commented May 7, 2014

Reflect that they take a regexp rather than a string.

@ggilder
Copy link
Contributor Author

ggilder commented May 7, 2014

cc @jkingdon @tamird @robolson

@@ -8,13 +8,13 @@
class Gem::Commands::ListCommand < Gem::Commands::QueryCommand

def initialize
super 'list', 'Display local gems whose name starts with STRING'
super 'list', 'Display local gems whose name contains REGEXP'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches REGEXP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, revising

@tamird
Copy link

tamird commented May 7, 2014

👍

Reflect that they take a regexp rather than a string.
@jkingdon
Copy link

jkingdon commented May 7, 2014

Looks good to me.

@stupied4ever
Copy link

👍 nice job

@drbrain drbrain added this to the 2.3 milestone May 8, 2014
drbrain added a commit that referenced this pull request May 8, 2014
@drbrain drbrain merged commit 39ca4aa into rubygems:master May 8, 2014
drbrain added a commit that referenced this pull request May 8, 2014
zzak pushed a commit to zzak/rubygems that referenced this pull request May 9, 2014
chancancode added a commit to chancancode/rubygems that referenced this pull request Apr 20, 2015
zzak pushed a commit that referenced this pull request Apr 26, 2015
Fix doc for `gem list` (follow-up for #905)
@chancancode chancancode mentioned this pull request Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants