New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Native File::PATH_SEPARATOR and remove $ before gem env #915
Conversation
Use Native File::PATH_SEPARATOR and remove $ before gem env
❤️ I love the file separator idea, had no clue that constant existed. I'm only okay on removing $ but it's my own personal convention http://www.schneems.com/post/60359275700/prepare-do-test-make-your-technical-writing-shine/ 😀 . Either way thanks for helping out 👍 |
Interesting post! We use it heavily as well over on http://jekyllrb.com. It has always felt weird in command-line tool output, though. Just a personal preference, I suppose. 😄 Cheers! 🍻 |
@schneems @parkr perhaps is because I'm not a native english speaker but if you say:
I understand that I need to execute
(and trust me, happens more often that you would admit). The convention of I've seen people with no background on Ruby, Rails or Bundler trying get a site working powered by Jekyll, either Mac or Windows. |
I think it would be best to say an action word such as
Would be good. Otherwise they may think they need to go into
At least if they did this, they may re-visit the wording and realize that I choose the word |
Specificity is certainly important. I think where the prefix becomes necessary is when there are multiple lines, e.g.: $ gem env
$ gem list The prefix is then used to indicate that those commands are separate, in addition to being shell commands. I think
|
AFAIK the other documentation in rubygems doesn't use $ before commands. PS: I remember being confused by |
Address @luislavena's comment: #913 (comment)
/cc @schneems for the awesome patch.
Follow-up to #913.