Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2.4/2.5 rubies #21

Merged
merged 15 commits into from Jun 4, 2018
Merged

Support 2.4/2.5 rubies #21

merged 15 commits into from Jun 4, 2018

Conversation

razum2um
Copy link
Contributor

@razum2um razum2um commented Jun 1, 2018

After this the gem should properly work on ruby 1.9-2.5 inclusively, without warnings 馃帀

What's addressed inside:

  • warnings/missing Fixnum/Bignum/Data
  • new FrozenError
  • fixes related updated bundler, webrick, ox

What I'm concerned about (maybe we'd better change test logic)

  • some workarounds for a ruby bug with line numbers and new did-you-mean enabled by default
  • I had to change openssl verify_depth to 0 since with 1 the insufficient cert chain doesn't raise (both travis & locally the same) - if you understand this, please, tell me what you think :)

Also handled some things discussed in #8 which should make further testing more predictable

  • time-dependent specs are executed with stubbed time
  • errors caused by "port is used" are auto retried now

What's totally broken after this:

  • ruby-1.8
  • anything with libxmlparser

Sorry for a big PR, feel free to take some commits apart and comment on.

@razum2um razum2um mentioned this pull request Jun 1, 2018
@rubyjedi
Copy link
Owner

rubyjedi commented Jun 4, 2018

Thanks for the PR!

Looks good; I've no problem with libxmlparser being broken for the time being - I don't think that's really in demand these days with the more modern parsers available as options. 'Would like to get that working again for completeness' sake, but that can be a battle for another day.

Merging. Again, thanks for all the time and effort put into forward-porting to Ruby 2.4 and 2.5

@rubyjedi rubyjedi merged commit 0922205 into rubyjedi:master Jun 4, 2018
@razum2um
Copy link
Contributor Author

razum2um commented Jun 5, 2018

@rubyjedi thanks 馃憤 could you also release to rubygems?

@razum2um
Copy link
Contributor Author

razum2um commented Mar 5, 2019

@rubyjedi thanks, sorry for a necroreply, but I saw you pulished soap4r-ng-2.0.4, but could you bump rubyjedi-soap4r since it has almost twice more downloads (more dependent packages I think) but the code inside is the same, just not to change all 3rd party deps and just update the transitive (rubyjedi-soap4r) one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants