New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 2.4/2.5 rubies #21
Conversation
Thanks for the PR! Looks good; I've no problem with libxmlparser being broken for the time being - I don't think that's really in demand these days with the more modern parsers available as options. 'Would like to get that working again for completeness' sake, but that can be a battle for another day. Merging. Again, thanks for all the time and effort put into forward-porting to Ruby 2.4 and 2.5 |
@rubyjedi thanks 馃憤 could you also release to rubygems? |
@rubyjedi thanks, sorry for a necroreply, but I saw you pulished |
After this the gem should properly work on ruby 1.9-2.5 inclusively, without warnings 馃帀
What's addressed inside:
What I'm concerned about (maybe we'd better change test logic)
Also handled some things discussed in #8 which should make further testing more predictable
What's totally broken after this:
Sorry for a big PR, feel free to take some commits apart and comment on.