Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built v8 is not being used in ruby platform tests. #40

Closed
seanmakesgames opened this issue Jan 22, 2023 · 1 comment
Closed

Built v8 is not being used in ruby platform tests. #40

seanmakesgames opened this issue Jan 22, 2023 · 1 comment

Comments

@seanmakesgames
Copy link
Contributor

Something I just noticed about the ruby platform tests: They don't seem to use the ruby platform gem at all.
It's compiled and installed alright, but the actual "Test with mini_racer" step then turns around and downloads libv8-node with the "correct" arch + libc from https://rubygems.org/

Originally posted by @Fayti1703 in #37 (comment)
@seanmakesgames seanmakesgames mentioned this issue Jan 22, 2023
Merged
@seanmakesgames
Copy link
Contributor Author

Fixed in #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanmakesgames