upgrade v8 version

[seanmakesgames]

There's a tasty new version of v8 available. We should get it. ;)

[ignisf]

Already in the libv8 repo, was thinking about a pre-release

[seanmakesgames]

excellent @ignisf !

[ignisf]

oh yeah.. wait... the libv8 master is already at 5.6 :P

[seanmakesgames]

@SamSaffron just a dependency upgrade then?

[SamSaffron]

Yes please, do a PR to upgrade us to 56 ... as a rule of thumb I am perfectly happy upgrading the dependency to latest stable when v8 stable is released.

…

On Tue, Mar 7, 2017 at 3:02 PM, seanmakesgames ***@***.***> wrote: @SamSaffron <https://github.com/SamSaffron> just a dependency upgrade then? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#53 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAUXdLTP9i-utnO7vKgQ9vZ6trxZfPNks5rjbfCgaJpZM4MV5C_> .

[SamSaffron]

@ignisf can you do a new release of libv8 ? would love to upgrade our dependency to 5.6, chrome stable is on 56 these days (58 btw is going to be very exciting cause there are some very exciting optimisations enabled by default)

[ignisf]

Was just about to do that... I'm going to need a server farm soon to produce all the binaries, seeing how much time it takes me :D. Will try to cut a pre-release first, @seanmakesgames which OSes are you using to develop and test so I can prioritise them?

[seanmakesgames]

@ignisf server ubuntu 14.04 64; dev macos 10.11.6

[ignisf]

linux binary up, macos binaries as soon as Travis is finished compiling them up.

[ignisf]

https://rubygems.org/gems/libv8/versions/5.6.326.50.0beta1 🎉

[seanmakesgames]

awesome :D
Sorry for the slowness, updating my branch and checking out my game's test suite.

[seanmakesgames]

updated gemspec locally, mini_racer tests all run great. Doing the game ones now (takes a bit)

[seanmakesgames]

Everything looks good with the 5.6.326.50.0beta1 version in my mac dev environment. :)
Once '~> 5.6' is a thing that works in the gemspec, I can make PR.

[ignisf]

I have those https://github.com/cowboyd/libv8/milestone/4 to fix before I release a stable version. Maybe you could focus on the OOM stuff in the meantime? I'll try to do it later today (it's 2AM here).

[seanmakesgames]

haha yeah, it's no problem at all.
Thanks for the support! Keep us posted. :D

[seanmakesgames]

ping @ignisf

[ignisf]

I'm finally ready for a release. 5.7.492.65.0 is imminent

[seanmakesgames]

Oh! 5.7 eh? Nice :D

[ignisf]

beta up for testing. Take it for a spin with your test suites please and ping me afterwards.

[seanmakesgames]

Will do! Thanks @ignisf

[seanmakesgames]

@ignisf ugh I totally haven't forgotten about this-- it's been sitting on my todolist this whole time. Few fires at work totally deprioritized this. Definitely haven't forgotten about it though.

[krzysiek1507]

Hi @seanmakesgames any news? ;)

[seanmakesgames]

Thanks for the ping @krzysiek1507 -- Running the test suite now! :D

[seanmakesgames]

@ignisf @krzysiek1507 Tests are all passing here. Ready for a release so I can 'test it out' on production. ;)

[ignisf]

acknowledged. Will ping you when ready.

[seanmakesgames]

Sorry it took forever.

[krzysiek1507]

@seanmakesgames I hope your production still works. 😄

[seanmakesgames]

haha-- we'll find out soon enough. This game is broken by design, so 'works' is up to interpretation. ;)

[SamSaffron]

just wanted to note here, that my goal for MiniRacer has always been always to be on latest stable v8.

[seanmakesgames]

Once this one gets out, we can start work on the next version?

[ignisf]

released. Working on 5.9 in the respective branch.

[SamSaffron]

@ignisf I just bumped mini racer, but when I updated discourse I see this in my lockfile

-    libv8 (5.7.492.65.1)
+    libv8 (5.9.211.38.1-x86_64-linux)

Any idea why it is happening? (the linux suffix)

[SamSaffron]

MiniRacer is updated 🥇 btw, huge thanks, the benches are a bit of a mixed bag, not a huge win for our workloads and in many places a small loss.

[ignisf]

Did you update a Discourse instance running on Linux? If that's the case, then your rubygems preferred the binary version of the gem for Linux, which is the expected behaviour.

[SamSaffron]

I did, I ended up just removing the suffix and all seems fine