update to libv8 6.0 #65

seanmakesgames · 2017-08-24T16:41:55Z

am running my test suite against 6.0.286.54.0beta1
wanted a place to write down the results. :)
@SamSaffron @ignisf

seanmakesgames · 2017-08-24T18:32:10Z

I'm getting

mkdir -p tmp/x86_64-darwin15/mini_racer_extension/2.2.4
cd tmp/x86_64-darwin15/mini_racer_extension/2.2.4
/Users/user/.rvm/rubies/ruby-2.2.4/bin/ruby -I. ../../../../ext/mini_racer_extension/extconf.rb
checking for main() in -lpthread... yes
checking for main() in -lobjc... yes
creating Makefile
cd -
cd tmp/x86_64-darwin15/mini_racer_extension/2.2.4
/usr/bin/make
compiling ../../../../ext/mini_racer_extension/mini_racer_extension.cc
clang: warning: argument unused during compilation: '-rdynamic'
linking shared-object mini_racer_extension.bundle
clang: warning: libstdc++ is deprecated; move to libc++
ld: unknown option: --start-group
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [mini_racer_extension.bundle] Error 1
rake aborted!
Command failed with status (2): [/usr/bin/make...]
/Users/user/.rvm/gems/ruby-2.2.4/gems/rake-compiler-0.9.9/lib/rake/extensiontask.rb:157:in `block (2 levels) in define_compile_tasks'
/Users/user/.rvm/gems/ruby-2.2.4/gems/rake-compiler-0.9.9/lib/rake/extensiontask.rb:156:in `block in define_compile_tasks'
/Users/user/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `eval'
/Users/user/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => compile => compile:x86_64-darwin15 => compile:mini_racer_extension:x86_64-darwin15 => copy:mini_racer_extension:x86_64-darwin15:2.2.4 => tmp/x86_64-darwin15/mini_racer_extension/2.2.4/mini_racer_extension.bundle
(See full trace by running task with --trace)

on rake clean compile

is my platform built @ignisf or am I doing something else wrong?

seanmakesgames · 2017-08-24T19:11:19Z

looks like this issue is #66 and I think related to the --start-group linker error (unknown option)
The weird thing is that it's inconsistent on when it shows up. Will resolve on other issue.

ignisf · 2017-08-24T19:18:04Z

rubyjs/libv8@9977436

seanmakesgames · 2017-08-24T19:29:20Z

haha thanks @ignisf -- can't tell if this is introducing the issue or fixing it? Assuming introduces, but don't understand how this is happening on mini_racer mainline (through bundler) when dependency is @ 5.9
Maybe my grasp of what bundler is doing is poor. :\

ignisf · 2017-08-24T19:36:43Z

I'll revert this commit and release another beta. Bundler is not selecting the correct version of libv8 I think. Try uninstalling 6.*. Sorry for taking so long to respond. My ISP has a broken optical connection.

seanmakesgames · 2017-08-24T19:37:51Z

it's all good @ignisf! Thanks for the response.
Good luck with your internet!

seanmakesgames · 2017-08-24T19:45:38Z

You were right-- uninstalling 6.0 got the correct libv8 version to load up, and has isolated the issue to 6.0beta. Thanks for the help @ignisf :)
Awaiting new beta for testing.

ignisf · 2017-08-25T10:44:34Z

6.0 beta2 is up

seanmakesgames · 2017-08-25T14:35:40Z

Everything works @ignisf thanks!
Running test suite now.

seanmakesgames · 2017-08-25T14:56:46Z

Tests all check out. :)

ignisf · 2017-08-26T16:48:05Z

6.0 released 🎉

krzysiek1507 · 2017-08-29T08:03:45Z

@seanmakesgames are you testing it on production again? :D

ignisf · 2017-08-29T08:17:35Z

That's just how he roll :)

krzysiek1507 · 2017-08-29T08:20:02Z

Can you see significant performance improvement?

seanmakesgames · 2017-08-29T15:13:18Z

Haha, nah-- was running against my test suite. I'll be 'testing on production' once mini_racer has upped its version number. ;)

I didn't do any benchmarking as part of my test cases because I run them multicore. It did 'feel' faster, but that's not useful information. :P

krzysiek1507 · 2017-08-29T15:50:34Z

Haha. When I updated Node to 8.4.0 (with v8 6.0) it was about 40% faster.
Do you have any ETA? :)

seanmakesgames · 2017-08-29T15:59:17Z

That's a question for @SamSaffron (whom I'm sure is busy atm, or he'd probably have said something already) ;)

SamSaffron · 2017-08-31T00:27:20Z

@krzysiek1507 I don't have an eta, but once @seanmakesgames is happy that 6.0 is stable I am happy to bounce the version.

My initial testing definitely did not show a 40% improvement in my microbench maybe 5-10%

SamSaffron · 2017-08-31T00:27:49Z

Note, I am travelling over the next 3 weeks so I am not 100% sure I will be super fast here.

krzysiek1507 · 2017-08-31T07:40:46Z

Thanks, guys! You are doing great work!

seanmakesgames · 2017-08-31T15:20:46Z

@SamSaffron 6.0 appears stable. I'm good with a rev bump.

krzysiek1507 · 2017-09-01T06:27:44Z

When I installed it from my repo I saw error:

/bundle/bin/rake assets:precompile: symbol lookup error: /bundle/bundler/gems/mini_racer-458c7fafa7a0/lib/mini_racer_extension.so: undefined symbol: _ZN2v84base5debug27EnableInProcessStackDumpingEv

Version: libv8 6.0.286.54.1 (x86_64-linux) on Debian jessie

krzysiek1507 · 2017-09-18T11:33:09Z

Any update on this?

SamSaffron · 2017-09-21T16:09:32Z

Will do another release next week

krzysiek1507 · 2017-09-21T17:11:05Z

Thanks!

SamSaffron · 2017-09-25T03:04:08Z

confirmed @ignisf getting:

/home/sam/.rbenv/versions/2.3.1/bin/ruby: symbol lookup error: /home/sam/Source/mini_racer/lib/mini_racer_extension.so: undefined symbol: _ZN2v84base5debug27EnableInProcessStackDumpingEv

on GCC with 6.0.286 , can you have a look?

ignisf · 2017-09-25T07:57:12Z

morning, back from vacation, will try to check it out

SamSaffron · 2017-09-25T07:58:33Z

cool, thanks!

…

On Mon, Sep 25, 2017 at 5:57 PM, Petko Bordjukov ***@***.***> wrote: morning, back from vacation, will try to check it out — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAUXSX6oyCLRm5DTEelNxDxhjnk_oNKks5sl1zZgaJpZM4PBotX> .

ignisf · 2017-10-23T22:09:21Z

the missing symbol was due to the reordering of the libraries. Who knew Google's wiki would lie... Should be fixed in master and the 6.0 branches

ignisf · 2017-12-13T13:25:30Z

ignisf · 2017-12-13T16:20:01Z

just an FYI, we will be losing FreeBSD support with this version due to lack of upstream support. I decided to not hold up the release more. Will hopefully work out a solution and release binaries at a later stage.

seanmakesgames · 2017-12-13T19:06:25Z

Fine by me. ;)
I'm excited to see how this release performs in the live environment. 😄

SamSaffron · 2017-12-14T07:39:09Z

OK, my plan for tomorrow is to bench it on Discourse!

SamSaffron · 2017-12-15T01:45:54Z

This is not great... my bench suite for discourse is hanging ....

…

On Thu, Dec 14, 2017 at 6:06 AM, seanmakesgames ***@***.***> wrote: Fine by me. ;) I'm excited to see how this release performs in the live environment. 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAUXd2_6bZJAtx988KhpD3DbVziT7SIks5tACAxgaJpZM4PBotX> .

SamSaffron · 2017-12-15T01:48:54Z

Ouch ... 6.0 is hanging as well, this is looking like its probably a bug in mini_racer.

…

On Fri, Dec 15, 2017 at 12:45 PM, Sam Saffron ***@***.***> wrote: This is not great... my bench suite for discourse is hanging .... On Thu, Dec 14, 2017 at 6:06 AM, seanmakesgames ***@***.***> wrote: > Fine by me. ;) > I'm excited to see how this release performs in the live environment. 😄 > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#65 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAAUXd2_6bZJAtx988KhpD3DbVziT7SIks5tACAxgaJpZM4PBotX> > . >

seanmakesgames · 2017-12-15T02:11:46Z

That's strange. My full test suite passed. :\

SamSaffron · 2017-12-15T03:54:33Z

oops @ignisf looks like 6.2 is hanging for me during script runs. I will try to build a repro for this. I wonder if this was a temporary bug in v8 or if it is fixed in 6.3

6.0 seems to work fine though.

SamSaffron · 2017-12-15T03:56:39Z

the repro of the bug is to run: https://github.com/discourse/discourse/blob/master/script/benchmarks/markdown/bench.rb but that involves a full discourse install...

ignisf · 2017-12-15T08:36:16Z

will look into building betas for 6.1 and 6.3

ignisf · 2017-12-18T15:32:39Z

@SamSaffron, just released 6.3 beta.

SamSaffron · 2017-12-18T20:44:28Z

Oh no :( looks like this is hanging as well, going to create a simple repro script here and ask v8 folks for help.

ignisf · 2017-12-18T21:32:28Z

@SamSaffron, are you sure you're testing with mini_racer linked against the 6.3 beta and not by any chance linked against 6.2?

SamSaffron · 2017-12-18T22:22:49Z

yes, 100% 6.3.292.48.0beta1 in my gemfile lock ... trying to build a repro

SamSaffron · 2017-12-18T22:41:15Z

I am pretty sure this is the bug: https://bugs.chromium.org/p/v8/issues/detail?id=6933 Can you compile 6.4 to confirm it is fixed there? This kind of sucks cause it means we can not upgrade till 6.4 is released OR unless we backport it.

…

On Tue, Dec 19, 2017 at 8:32 AM, Petko Bordjukov ***@***.***> wrote: @SamSaffron <https://github.com/samsaffron>, are you sure you're testing with mini_racer linked against the 6.3 beta and not by any chance linked against 6.2? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAUXazuFYVy2lZi_fU1mBOLvN1ZCaN0ks5tBtnsgaJpZM4PBotX> .

SamSaffron · 2017-12-18T22:50:26Z

OK, v8 team say it backports very cleanly, can you try maybe adding that patch and doing another 6.3 release?

ignisf · 2017-12-18T23:08:50Z

Hey, sounds good, will look into backporting.

ignisf · 2017-12-18T23:25:53Z

rubyjs/libv8@5777dbd

Will cut another release for you to test tomorrow if the CI passes tonight :)

SamSaffron · 2017-12-19T00:27:59Z

Awesome! Thanks for that!

…

On Tue, Dec 19, 2017 at 10:25 AM, Petko Bordjukov ***@***.***> wrote: ***@***.*** <rubyjs/libv8@5777dbd> Will cut another release tomorrow if the CI passes tonight :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAUXTKAHYdHtq0ljKb2IXY0GGLdE8Gbks5tBvSBgaJpZM4PBotX> .

ignisf · 2017-12-19T10:18:15Z

seanmakesgames · 2017-12-19T16:42:17Z

@SamSaffron let me know when you've tested the patch on this. I'll run my suite against it after.

SamSaffron · 2017-12-20T01:17:00Z

Looking good on my side! @ignisf bench is no longer hanging, 6.3 appears slower than 5.9 in some of the bench suite (and faster in other bits):

5.9

tiny post sanitize: true
                        129.364  (±10.8%) i/s -    636.000  in   5.014269s
giant post sanitize: true
                        106.396  (±10.3%) i/s -    530.000  in   5.073153s
most features sanitize: true
                         54.285  (± 7.4%) i/s -    272.000  in   5.039917s
lots of mentions sanitize: true
                          0.404  (± 0.0%) i/s -      3.000  in   7.428951s
tiny post sanitize: false
                        284.413  (± 8.8%) i/s -      1.430k in   5.071733s
giant post sanitize: false
                        207.441  (± 7.2%) i/s -      1.050k in   5.092453s
most features sanitize: false
                         74.881  (± 6.7%) i/s -    378.000  in   5.071991s
lots of mentions sanitize: false
                          0.403  (± 0.0%) i/s -      3.000  in   7.441425s
markdown it no extensions commonmark tiny post
                          7.832k (± 4.3%) i/s -     39.744k in   5.083833s
markdown it no extensions commonmark giant post
                        916.757  (± 9.5%) i/s -      4.550k in   5.054635s
markdown it no extensions commonmark most features
                          1.493k (± 6.3%) i/s -      7.560k in   5.087277s
markdown it no extensions commonmark lots of mentions
                          2.089k (± 5.5%) i/s -     10.556k in   5.070508s

6.3

tiny post sanitize: true
                        129.675  (±10.8%) i/s -    648.000  in   5.070792s
giant post sanitize: true
                        106.214  (±10.4%) i/s -    530.000  in   5.057866s
most features sanitize: true
                         52.109  (±11.5%) i/s -    260.000  in   5.054359s
lots of mentions sanitize: true
                          0.335  (± 0.0%) i/s -      2.000  in   5.988207s
tiny post sanitize: false
                        257.299  (±10.9%) i/s -      1.288k in   5.073169s
giant post sanitize: false
                        208.196  (± 9.6%) i/s -      1.050k in   5.093251s
most features sanitize: false
                         75.199  (± 6.6%) i/s -    378.000  in   5.053536s
lots of mentions sanitize: false
                          0.393  (± 0.0%) i/s -      2.000  in   5.091215s
markdown it no extensions commonmark tiny post
                          7.643k (± 4.3%) i/s -     38.743k in   5.078730s
markdown it no extensions commonmark giant post
                        934.341  (±12.2%) i/s -      4.592k in   5.079925s
markdown it no extensions commonmark most features
                          1.472k (± 3.6%) i/s -      7.452k in   5.068865s
markdown it no extensions commonmark lots of mentions
                          2.054k (± 6.9%) i/s -     10.400k in   5.095029s

Benchmark is: https://github.com/discourse/discourse/blob/master/script/benchmarks/markdown/bench.rb

ignisf · 2017-12-20T16:05:31Z

.0 and .1 releases are up on rubygems.

seanmakesgames · 2017-12-20T20:22:43Z

prepping to run the suite on this (have been making changes, so want to make sure tests are passing first) ;)
Will be running tests against 6.3.292.48.1 and let you know how it goes.

seanmakesgames · 2017-12-20T21:12:43Z

everything looks good on my end. tests pass. no funky behavior (more than usual) :P

SamSaffron · 2017-12-22T07:05:59Z

It is holiday season, I will try to get a new stable out next week, but will only upgrade Discourse the week after

SamSaffron · 2017-12-27T21:53:52Z

thanks heaps @ignisf for the work on libv8 6.3 we now have a new release.

Napolskih · 2018-01-25T14:44:46Z

What about 6.4? They promise a significant optimization.

ignisf · 2018-01-25T15:22:22Z

I too am eager to push libv8 6.4. Just have to find some time to do so.

seanmakesgames mentioned this issue Aug 24, 2017

Error linking during bundle on MacOS #66

Closed

SamSaffron closed this as completed in 15e7342 Dec 27, 2017

update to libv8 6.0 #65

update to libv8 6.0 #65

Comments

seanmakesgames commented Aug 24, 2017

seanmakesgames commented Aug 24, 2017

seanmakesgames commented Aug 24, 2017

ignisf commented Aug 24, 2017

seanmakesgames commented Aug 24, 2017

ignisf commented Aug 24, 2017

seanmakesgames commented Aug 24, 2017

seanmakesgames commented Aug 24, 2017

ignisf commented Aug 25, 2017

seanmakesgames commented Aug 25, 2017

seanmakesgames commented Aug 25, 2017

ignisf commented Aug 26, 2017

krzysiek1507 commented Aug 29, 2017

ignisf commented Aug 29, 2017

krzysiek1507 commented Aug 29, 2017 • edited

seanmakesgames commented Aug 29, 2017

krzysiek1507 commented Aug 29, 2017

seanmakesgames commented Aug 29, 2017 • edited

SamSaffron commented Aug 31, 2017

SamSaffron commented Aug 31, 2017

krzysiek1507 commented Aug 31, 2017

seanmakesgames commented Aug 31, 2017

krzysiek1507 commented Sep 1, 2017 • edited

krzysiek1507 commented Sep 18, 2017

SamSaffron commented Sep 21, 2017

krzysiek1507 commented Sep 21, 2017

SamSaffron commented Sep 25, 2017

ignisf commented Sep 25, 2017

SamSaffron commented Sep 25, 2017 via email

ignisf commented Oct 23, 2017

ignisf commented Dec 13, 2017

ignisf commented Dec 13, 2017 • edited

seanmakesgames commented Dec 13, 2017

SamSaffron commented Dec 14, 2017

SamSaffron commented Dec 15, 2017 via email

SamSaffron commented Dec 15, 2017 via email

seanmakesgames commented Dec 15, 2017

SamSaffron commented Dec 15, 2017

SamSaffron commented Dec 15, 2017

ignisf commented Dec 15, 2017

ignisf commented Dec 18, 2017 • edited

SamSaffron commented Dec 18, 2017

ignisf commented Dec 18, 2017

SamSaffron commented Dec 18, 2017

SamSaffron commented Dec 18, 2017 via email

SamSaffron commented Dec 18, 2017

ignisf commented Dec 18, 2017

ignisf commented Dec 18, 2017 • edited

SamSaffron commented Dec 19, 2017 via email

ignisf commented Dec 19, 2017

seanmakesgames commented Dec 19, 2017

SamSaffron commented Dec 20, 2017 • edited

5.9

6.3

ignisf commented Dec 20, 2017

seanmakesgames commented Dec 20, 2017

seanmakesgames commented Dec 20, 2017

SamSaffron commented Dec 22, 2017

SamSaffron commented Dec 27, 2017

Napolskih commented Jan 25, 2018

ignisf commented Jan 25, 2018

krzysiek1507 commented Aug 29, 2017 •

edited

seanmakesgames commented Aug 29, 2017 •

edited

krzysiek1507 commented Sep 1, 2017 •

edited

ignisf commented Dec 13, 2017 •

edited

ignisf commented Dec 18, 2017 •

edited

ignisf commented Dec 18, 2017 •

edited

SamSaffron commented Dec 20, 2017 •

edited