Replaced rendering db and auth passwords with BOSH interpolation #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vshatravenko
commented
Oct 9, 2017
vshatravenko
commented
- Removed empty docs folder from tpl/skel
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 46.57% 46.57%
=======================================
Files 14 14
Lines 277 277
=======================================
Hits 129 129
Misses 148 148Continue to review full report at Codecov.
|
mod
reviewed
Oct 9, 2017
| @@ -8,4 +8,4 @@ bosh -e <%= @values['bosh']['name'] %> upload-release https://github.com/concour | |||
| bosh -e <%= @values['bosh']['name'] %> upload-release https://github.com/concourse/concourse/releases/download/v3.4.1/garden-runc-1.6.0.tgz | |||
|
|
|||
| # Deploy Concourse | |||
There was a problem hiding this comment.
@vshatravenko We can do better than that
first we need a helper kite for generator strong password
also we should save generated password.
vault token is another token but we could save it also in the a vars files
then we can have a bosh vars file full of passwords, file we can save later in vault or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.