-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nokogiri dependency throws deprecation warnings in Ruby 2.4.0 #54
Comments
@bovender sure, but it needs to be ruby version dependent, since Nokogiri 1.7 also dropped support for older rubies |
Ah ok, sure. Unfortunately I'm unable to help with that -- don't know enough about Gemspec dependencies. |
No problem, I'll add this one |
May I ask one more thing -- the ruby version-dependent dependency somehow does not work: $ bundle update
Fetching gem metadata from https://rubygems.org/...........
Fetching version metadata from https://rubygems.org/..
Fetching dependency metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "nokogiri":
In Gemfile:
nokogiri (~> 1.7.0)
eu_central_bank (~> 1.0) was resolved to 1.0.0, which depends on
nokogiri (~> 1.6.3)
$ irb
irb(main):001:0> puts RUBY_VERSION
2.4.0
=> nil
irb(main):002:0> The Maybe this is not the right place to ask this, but maybe I'm just missing something simple. |
So it says that |
I really don't mean to be a nuisance, but the output is the same when I fix the version at 1.1.0 in the Gemfile. When I download the gem from RubyGems.org and extract the files, the
When I clone the repository and build the gem myself using Ruby 2.4.0, I find this inside the
Which makes me wonder if the |
@bovender sounds like you're right… and a quick search revealed the fact that it might be impossible to achieve. So it seems like we need to relax the dependency on the gem ( |
@antstorm Maybe just put it to readme that if you're using older Ruby < 2.4.0, use X version of this gem? |
@ahukkanen it would make sense to drop the support of Ruby <= 2.0, yes, since it's what causing most of the issues right now. I wonder how many people are still running older rubies… |
Yeah, that's true, too. I would guess not that many people. |
I guess it's time to do that :) |
The Gemspec requires Nokogiri:
Which triggers tons of deprecation warnings with Ruby 2.4.0 because of the Fixnum/Bignum deprecation.
It's fixed in Nokogiri 1.7.0 (sparklemotion/nokogiri#1564).
Is it possible to relax the dependency?
The text was updated successfully, but these errors were encountered: