Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixnum is deprecated warning under Ruby 2.4.0 and Nokogiri 1.6.8.1 #1564

Closed
memoht opened this issue Dec 25, 2016 · 1 comment
Closed

Fixnum is deprecated warning under Ruby 2.4.0 and Nokogiri 1.6.8.1 #1564

memoht opened this issue Dec 25, 2016 · 1 comment
Milestone

Comments

@memoht
Copy link

memoht commented Dec 25, 2016

Upgraded to Ruby 2.4.0 last night and upon launching app in development was greeted with the following in the console: nokogiri-1.6.8.1/lib/nokogiri/html/document.rb:164: warning: constant ::Fixnum is deprecated

Thought this was solved in #1545 but seeing a redx in the commit history for this merge, so guessing something still isn't resolved.

Using: macOS Sierra 10.12.2
App is using: Rails 5.0.1

| => nokogiri -v
# Nokogiri (1.6.8.1)
    ---
    warnings: []
    nokogiri: 1.6.8.1
    ruby:
      version: 2.4.0
      platform: x86_64-darwin16
      description: ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin16]
      engine: ruby
    libxml:
      binding: extension
      source: packaged
      libxml2_path: "/Users/memoht/Sites/ppipub/.gem/ruby/2.4.0/gems/nokogiri-1.6.8.1/ports/x86_64-apple-darwin16.3.0/libxml2/2.9.4"
      libxslt_path: "/Users/memoht/Sites/ppipub/.gem/ruby/2.4.0/gems/nokogiri-1.6.8.1/ports/x86_64-apple-darwin16.3.0/libxslt/1.1.29"
      libxml2_patches: []
      libxslt_patches: []
      compiled: 2.9.4
      loaded: 2.9.4
@larskanis larskanis added this to the 1.7.0 milestone Dec 25, 2016
@larskanis
Copy link
Member

This is already fixed on the git master branch and will be part of the next release. The red X is only about a failed test, but the PR #1545 is merged nevertheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants