Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox to accept code of conduct when updating profile #1173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

athomschke
Copy link
Contributor

  • Links to CoC in new tab
  • Needs to be checked in order to submmit the changes
  • Is not persisted - needs to be accepted each time the profile is updated

#1116

* Links to CoC in new tab
* Needs to be checked in order to submmit the changes
* Is not persisted - needs to be accepted each time the profile is updated
@athomschke
Copy link
Contributor Author

Screenshot 2021-10-03 at 12 23 55

Screenshot 2021-10-03 at 12 24 00

Screenshot 2021-10-03 at 12 24 11

Screenshot 2021-10-03 at 12 24 17

@tyranja
Copy link
Member

tyranja commented Oct 12, 2021

@athomschke

@zaziemo and I gave this feature some thoughts yesterday and we would rather do a different kind of approach here. Because we are afraid some users will not know what to do here and get stuck.

  1. We save the confirmation in the DB and add some validation in the model with a good error message, so the user know exactly why saving failed
  2. We used the bootstrap validation-> https://getbootstrap.com/docs/5.1/forms/validation/. Here we also get a understandable error message

Let's talk about that next meeting 💕

@athomschke
Copy link
Contributor Author

We just talked - the agreement is that we store the flag per-profile, so that Speakerinnen, once this is merged, need to accept the CoC one time. Ideally, a Speakerin also cannot uncheck this setting once it has been accepted once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants