Adjust sanitization code to allow HTML5 'data-' attributes through. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ough because they have no meaning to a browser or SGML parser and may contain meta-data or other attributes that scripts added to the planet page may require.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I have made two minor modifications to files in the
planet/vendorfolder.Both
planet/vendor/feedparser.pyandplanet/vendor/html5lib/sanitizer.py(which are used for sanitizing the HTML / XHTML encountered in a feed) strip out HTML5 data attributes. These attributes have no meaning to the browser (they are ignored) but third party scripts that are added to the planet page may make use of these attributes and having them stripped out breaks the scripts (or causes them to fail).Therefore, I have modified the two above files to allow these attributes to pass through the filtering / sanitization unaltered.
Please let me know if you have any questions / concerns.