Add SimpleCov into the mix to get C0 coverage stats. #53
Conversation
| @@ -1,3 +1,10 @@ | |||
| version = RUBY_VERSION.split(/\./).map(&:to_i) | |||
| if((version[0] == 1 && version[1] >= 9) || (version[0] >= 2)) | |||
There was a problem hiding this comment.
This patch looks fine other than this bit. Why restrict simplecov to Ruby 1.. when 2.1.2 is current?
There was a problem hiding this comment.
Note the || (version[0] >= 2) portion.
It's restricted to Ruby 1.9.x, or 2.0.0+ -- so any subsequent version, including a hypothetical 3.0 would pass.
There was a problem hiding this comment.
The first conditional is there only to ensure that it isn't utilized on Ruby 1.8.x or below, as SimpleCov does not work on versions prior to 1.9.
There was a problem hiding this comment.
How about let's just make bundler-audit >= 1.9.1 and omit any version checks.
There was a problem hiding this comment.
If that's the consensus, I'll amend the PR tonight.
|
Closing. Will reopen a rebased version of this, with the specified changes momentarily. |
Plug in SimpleCov, as even the minimal guarantees provided by C0 coverage can prove handy for a security-related tool.