Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gets deletion time from paranoia_column #481

Merged
merged 1 commit into from Jan 19, 2022
Merged

gets deletion time from paranoia_column #481

merged 1 commit into from Jan 19, 2022

Conversation

sas1ni69
Copy link
Contributor

@sas1ni69 sas1ni69 commented Nov 28, 2019 •
edited

Using the recovery_window option with a custom column name raises an exception since the deleted_at value is hard coded.

@mathieujobin
Copy link
Collaborator

Can you rebase your branch with core, bump the version, and update the change log ?
Thanks

@sas1ni69 sas1ni69 force-pushed the fix-hard-coded-column-name branch 2 times, most recently from 975d9ef to 8e822cd Compare January 12, 2022 06:50
@sas1ni69
Copy link
Contributor Author

Thanks @mathieujobin I've updated it now. Let me know if you'd like me to change anything else.

@mathieujobin mathieujobin merged commit b6b5167 into rubysherpas:core Jan 19, 2022
@sherif-nedap sherif-nedap mentioned this pull request Mar 17, 2022
Closed
@mathieujobin
Copy link
Collaborator

@sas1ni69 Can you please have a look at the issue that was raised in #530 ? There is a test written for it in #531

The bug appears related to this change

thanks

@sas1ni69
Copy link
Contributor Author

@mathieujobin happy to 👍🏻

karunkumar1ly pushed a commit to edcast/paranoia that referenced this pull request Feb 6, 2024
@sas1ni69 @arun-zc
gets deletion time from paranoia_column (rubysherpas#481)
96b50fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieujobin mathieujobin mathieujobin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sas1ni69 @mathieujobin