Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow rails 7.0 #516

Merged
merged 10 commits into from
Dec 18, 2021
Merged

allow rails 7.0 #516

merged 10 commits into from
Dec 18, 2021

Conversation

mathieujobin
Copy link
Collaborator

Attempting an upgrade on Rails 7.
I need to bump this dependency.

@mathieujobin
Copy link
Collaborator Author

@mathieujobin
Copy link
Collaborator Author

@rubysherpas Any chance you could have a look at this PR ?

@mathieujobin
Copy link
Collaborator Author

@sevenseacat ^^

Thanks

@ryanwi ryanwi mentioned this pull request Dec 9, 2021
@rickychilcott
Copy link

Thank you for all of your work on this and other PRs @mathieujobin!

However, I'm not certain what is likely to happen with this one. Time will tell, but https://github.com/rubysherpas doesn't give much confidence that this account/organization is active. Moreover, http://rubysherpas.com/ is not an active domain any longer.

Since this has been open without any activity, have you considered officially forking and trying to maintain a different published gem? Or even more ideally, become maintainer of this gem?

@sevenseacat -- it looks likely you're working in Elixir these days so perhaps Ruby is no longer something you're excited to work in. Much appreciated for all of your work on this. Perhaps you could help provide some direction.

Thank you and happy holidays!

@mathieujobin
Copy link
Collaborator Author

I don't mind owning the gem, I inherited many already... https://rubygems.org/profiles/mathieu

but I would hate having to rename it, and to prevent that, I need push rights on rubygems.org

@rickychilcott @rubysherpas @sevenseacat

@radar radar mentioned this pull request Dec 18, 2021
@radar radar merged commit 3589589 into rubysherpas:core Dec 18, 2021
@radar
Copy link
Collaborator

radar commented Dec 18, 2021

@mathieujobin Wish granted.

@radar
Copy link
Collaborator

radar commented Dec 18, 2021

v2.5.0 released with these changes.

I'll stop ignoring notifications on this project now.

@rickychilcott
Copy link

Thank you @radar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants