Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to create test fixtures on JRuby #104

Closed
jkutner opened this issue Oct 22, 2013 · 2 comments
Closed

Failure to create test fixtures on JRuby #104

jkutner opened this issue Oct 22, 2013 · 2 comments

Comments

@jkutner
Copy link

jkutner commented Oct 22, 2013

Under JRuby, the rake command fails the first time. For example:

$ ruby -v 
jruby 1.7.5 (1.9.3p392) 2013-10-07 74e9291 on Java HotSpot(TM) 64-Bit Server VM 1.7.0_09-b05 [darwin-x86_64]
$ bundle exec rake
...
adding: data/file2.txt (deflated 79%)
deleting: data/file2.txt
    zip warning: zip file empty
RuntimeError: No such file or directory - data/generated/empty_chmod640.txt

ziptest.rb requires the Info-ZIP program 'zip' in the path
to create test data. If you don't have it you can download
the necessary test files at http://sf.net/projects/rubyzip.
  create_test_zips at /Users/jkutner/workspace/rubyzip/test/gentestfiles.rb:141
            (root) at /Users/jkutner/workspace/rubyzip/test/gentestfiles.rb:159

But if I remove line 96 from test/gentestfiles.rb the task works and all tests pass. Also, if the fixtures where created by MRI, then the tests pass under JRuby.

Are there any suggested work arounds? rubyzip is essential to Warbler, so I'm happy to help get it back under CI.
jkutner referenced this issue Oct 22, 2013
@simonoff
disable jRuby for a while
f6cb483
simonoff added a commit that referenced this issue Oct 22, 2013
@simonoff
fix jRuby Building #104
b676754
@jkutner
Copy link
Author

jkutner commented Oct 22, 2013

Thanks! I'll check into whether this is a JRuby bug or not. Feel free to ping me if you have any other JRuby issues.

@jkutner
Copy link
Author

jkutner commented Oct 23, 2013

Opened this: jruby/jruby#1149 -- and I'll look into the new JRuby failures that popped up.

@jkutner jkutner closed this as completed Oct 23, 2013
githubmo pushed a commit to githubmo/rubyzip that referenced this issue Jan 6, 2014
Merge branch 'master' of https://github.com/rubyzip/rubyzip into decr…
8fefc3f 
…ypt-perf

* 'master' of https://github.com/rubyzip/rubyzip:
  Explicitly add the released 2.1.0 Ruby version Remove branch restriction
  Fix Rubinius by adding newly required gems, updating label in .travis.yml
  Update README.md
  Update README.md
  Make File.open_buffer support Tempfiles
  Version bump
  Update Changelog with Ruby 1.9 requirement
  Update README to reflect 1.9 requirement
  Fix rubyzip#106 Set options about restoring ownerships, permissions and times. restore permissions enabled by default.
  fix jRuby Building rubyzip#104
  Fix rubyzip#28 and rubyzip#103
  disable jRuby for a while
  Fix rubyzip#102 recover file permissions if zip file was exist
  Add missing Zip::Entry arguments to Zip::File#get_output_stream. Fixes rubyzip#100
  fix string encoding of zip64 header ids for ruby 2.0
  Add read/write support for zip64 extensions

Conflicts:
	lib/zip/extra_field.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkutner