Created a bugfix fork of rubyzip #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added support for zip files with backslashes instead of slashes some packers produce zip files with commentLength set to 0 even though there is a comment after the EOCD (the Windows packer for example); this case is handled now
|
I'll be reviewing this shortly, but if you writing appropriate tests will speed inclusion |
|
have the same problem with "valid" zip file under windows. |
|
any news here? |
|
still no news? |
|
Can you add the test for your fix? |
muz
pushed a commit
to muz/rubyzip
that referenced
this pull request
Aug 6, 2014
Working AES-128, -192, -256 decryption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, my fork addresses backslashes in zip files and erroneous comment lengths in the EOCD structure.