prevent tempfile path from being unlinked by garbage collection #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibondarev
referenced
this pull request
in andreibondarev/rubyzip
Oct 4, 2014
simonoff
added a commit
that referenced
this pull request
Jan 16, 2015
prevent tempfile path from being unlinked by garbage collection
This was referenced Oct 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of our tests, we noticed that we were getting intermittent
Errno::ENOENT: No such file or directoryerrors here when reaching::File.rename(tmp_filename, self.name).After some investigation I found that the garbage collector happened to be running the finalizer for
tmpfileduring the entry writing block inFile#commit, which tries to unlink the file (and succeeds if you're on a non-Windows environment).