Be smarter about handling buffer file modes #201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #119.
The test suite still runs, but I have not added a test for this fix because I'm not sure if the behavior I defined is correct.
file.rb
): I noticed that the errors went away when I opened files in binary mode, likerubyzip
itself does when you pass a filename toZip::File.open
, so now it forces binary mode when you pass an IO object.output_stream.rb
): If you don't pass a stream which was opened for writing, then this results in a "not opened for writing" error, even if you didn't actually try to write anything.The second part is probably not correct; I imagine the best fix would be one that only bothers doing
zf.write_buffer(io)
if changes were actually made to the in-memory archive.