Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zip::FileSystem::ZipFsDir#glob #363

merged 2 commits into from Aug 22, 2018


Copy link

@hainesr hainesr commented Apr 30, 2018

This is an attempt to fix #356 by passing through the glob to the underlying implementation. This takes into account the current working directory within the zip archive.

Just pass the basic glob straight through to the underlying Zip::File
Copy link

coveralls commented Apr 30, 2018

Coverage Status

Coverage increased (+0.005%) to 96.529% when pulling aa6284d on hainesr:fix-dir-glob into 8887b70 on rubyzip:master.

@simonoff simonoff merged commit 6ea4a71 into rubyzip:master Aug 22, 2018
@hainesr hainesr deleted the fix-dir-glob branch August 22, 2018 09:55
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Zip::FileSystem::ZipFsDir#glob triggers non-existing Zip::FileSystem::ZipFileNameMapper#glob method
3 participants