Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync options and fix inconsistent behaviour of Zip::File#get_entry and Zip::File#find_entry. #423

Merged
merged 4 commits into from Dec 15, 2019

Conversation

hainesr
Copy link
Member

@hainesr hainesr commented Oct 31, 2019

See #422 for a detailed explanation of what is going on here.

This is the quick fix to ensure things are consistent for now. I will work up a PR with a longer term fix once we've decided what to do about it.

hainesr added 4 commits Oct 31, 2019
I have switched around the logic somewhat so that `get_entry` calls
`find_entry` and raises an exception if it gets `nil` back.
@coveralls
Copy link

coveralls commented Oct 31, 2019

Coverage Status

Coverage increased (+0.005%) to 95.459% when pulling f3a2f4a on hainesr:sync-options into 6389d65 on rubyzip:master.

Copy link
Member

@jdleesmiller jdleesmiller left a comment

LGTM!

@jdleesmiller
Copy link
Member

jdleesmiller commented Dec 15, 2019

(I looked back in the blame, and it seems like this inconsistency has always been here, but I don't see any rationale for the current behavior.)

@jdleesmiller jdleesmiller merged commit c925bdb into rubyzip:master Dec 15, 2019
2 checks passed
jdleesmiller added a commit that referenced this pull request Dec 15, 2019
@hainesr hainesr deleted the sync-options branch Dec 15, 2019
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants