Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI: Add useDeprecatedImplicitSecrets to legacy webui chart #174 #175

Merged
merged 2 commits into from
Oct 20, 2023
Merged

WebUI: Add useDeprecatedImplicitSecrets to legacy webui chart #174 #175

merged 2 commits into from
Oct 20, 2023

Conversation

ericvaandering
Copy link
Contributor

Fixes #174

@ericvaandering ericvaandering self-assigned this Oct 19, 2023
rcarpa
rcarpa reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@rcarpa rcarpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please fix the small linter problem.

@ericvaandering
Copy link
Contributor Author

OK, looks OK now I think.

@rcarpa rcarpa merged commit 361dbf7 into rucio:master Oct 20, 2023
1 check passed
@ericvaandering ericvaandering linked an issue Oct 20, 2023 that may be closed by this pull request
Clean up webui CA files too dmwm/CMSRucio#632
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcarpa rcarpa rcarpa approved these changes

@maany maany Awaiting requested review from maany

Assignees

@ericvaandering ericvaandering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add useDeprecatedImplicitSecrets to WebUI (v1) Clean up webui CA files too
2 participants
@ericvaandering @rcarpa