Homogenise restart templates #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command is comprised of a pipeline to: (1) produce a list of deployments, based on a label selector and (2) perform a rollout restart for each of these deployments. However, the label selector can be passed directly to the rollout restart. As such, there doesn’t appear a valid reason for implementing this in such a way. The entrypoint of the bitnami/kubectl container is ‘kubectl’, so it feels preferable to pass the command-line arguments with ‘args’.
The use of a set operator for a single-element set feels unnecessary.
There doesn’t appear to be a valid reason for including it. With this change, the two restart templates (in the server and the daemons) have become identical.
dchristidis
force-pushed
the
homogenise-restart-templates
branch
from
3dfc13b
to
c8ae805
Compare
rdimaio
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes should result in practically identical behaviour. Additional details in each commit message.